[Minor bug] activityBar.activeBackground not sync with it background

[CuongNgMan]

Versions (please complete the following information):

• OS: Windows 10
• VS Code version: latest
• Peacock Version: 3.3.1

Describe the bug

• There is a minor issue when I used Peacock with Shades of Purple theme
• As in the screen below, you can see that the active item color does not sync with activity bar's background

To Reproduce
Steps to reproduce the behavior:

1. Install Peacock
2. Install Shades of Purple theme and use it as default theme
3. Active Peacock
4. See error

Expected behavior

• The active item should have the same color as Activity Bar background

Screenshots

Additional context

• After several try, I found that these below settings are useful for this issue

• activityBar.activeBackground

• activityBar.activeBorder

• activityBar.activeFocusBorder

[johnpapa]

Thank you @CuongNgMan for creating this issue!

[johnpapa]

thanks.

have you tried this with other themes? are you sure it is just with that specific theme?

[CuongNgMan]

I only see this issue with that specific theme as of now.
But still, it would be better to make the color of activeBackground in sync with Activity Bar.

[MadeByMike]

I get this with all themes :(

[johnpapa]

Thanks for the details.

I think I see what is happening. Peacock does not set the activityBar.activeBackground. So if your theme uses that color, it could look odd. This would only be noticeable if the theme you use colors that setting, which is why I was not seeing it (and had not been reported before)

I think the appropriate fix would be to set the activityBar.activeBackground to the same color as Peacock sets the activityBar.background OR activityBar.activeBorder. The key is which one ... it may require a setting to toggle that.

For example

1. The left most image sets active background to the same as activitybar
2. The middle image sets active background to the same as activitybar's border
3. The middle image sets active background to the same as activitybar's border, but notice the badge clashes

For this reason I think choosing option 1 by default is the best. And this introduces no new settings. I'll work on this in a PR.

[johnpapa]

fix is now in 3.6.0

Notice the following image. The toolbar on the left is what peacock used to look like if a thee colored the activitybar activebackground. The image on the right shows what this fix does.