Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor bug] activityBar.activeBackground not sync with it background #345

Closed
CuongNgMan opened this issue Jan 30, 2020 · 6 comments
Closed

[Minor bug] activityBar.activeBackground not sync with it background #345

CuongNgMan opened this issue Jan 30, 2020 · 6 comments
Assignees
Labels
bug

Comments

@CuongNgMan
Copy link

@CuongNgMan CuongNgMan commented Jan 30, 2020

Versions (please complete the following information):

  • OS: Windows 10
  • VS Code version: latest
  • Peacock Version: 3.3.1

Describe the bug

  • There is a minor issue when I used Peacock with Shades of Purple theme
  • As in the screen below, you can see that the active item color does not sync with activity bar's background

To Reproduce
Steps to reproduce the behavior:

  1. Install Peacock
  2. Install Shades of Purple theme and use it as default theme
  3. Active Peacock
  4. See error

Expected behavior

  • The active item should have the same color as Activity Bar background

Screenshots
active item not sync

Additional context

  • After several try, I found that these below settings are useful for this issue

  • activityBar.activeBackground

  • activityBar.activeBorder

  • activityBar.activeFocusBorder

@johnpapa

This comment has been minimized.

Copy link
Owner

@johnpapa johnpapa commented Jan 30, 2020

Thank you @CuongNgMan for creating this issue!

@johnpapa

This comment has been minimized.

Copy link
Owner

@johnpapa johnpapa commented Feb 8, 2020

thanks.

have you tried this with other themes? are you sure it is just with that specific theme?

@CuongNgMan

This comment has been minimized.

Copy link
Author

@CuongNgMan CuongNgMan commented Feb 8, 2020

I only see this issue with that specific theme as of now.
But still, it would be better to make the color of activeBackground in sync with Activity Bar.

@MadeByMike

This comment has been minimized.

Copy link

@MadeByMike MadeByMike commented Feb 20, 2020

I get this with all themes :(

@johnpapa

This comment has been minimized.

Copy link
Owner

@johnpapa johnpapa commented Mar 8, 2020

Thanks for the details.

I think I see what is happening. Peacock does not set the activityBar.activeBackground. So if your theme uses that color, it could look odd. This would only be noticeable if the theme you use colors that setting, which is why I was not seeing it (and had not been reported before)

I think the appropriate fix would be to set the activityBar.activeBackground to the same color as Peacock sets the activityBar.background OR activityBar.activeBorder. The key is which one ... it may require a setting to toggle that.

For example

  1. The left most image sets active background to the same as activitybar
  2. The middle image sets active background to the same as activitybar's border
  3. The middle image sets active background to the same as activitybar's border, but notice the badge clashes

For this reason I think choosing option 1 by default is the best. And this introduces no new settings. I'll work on this in a PR.

image

@johnpapa johnpapa added the bug label Mar 8, 2020
@johnpapa johnpapa self-assigned this Mar 8, 2020
@johnpapa johnpapa mentioned this issue Mar 9, 2020
9 of 9 tasks complete
@johnpapa johnpapa closed this in #365 Mar 9, 2020
@johnpapa

This comment has been minimized.

Copy link
Owner

@johnpapa johnpapa commented Mar 9, 2020

fix is now in 3.6.0

Notice the following image. The toolbar on the left is what peacock used to look like if a thee colored the activitybar activebackground. The image on the right shows what this fix does.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.