Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Spread the Settings to make them visible in the settings panel #47

Closed
JulianG opened this issue Mar 1, 2019 · 5 comments
Closed
Milestone

Comments

@JulianG
Copy link

JulianG commented Mar 1, 2019

The settings panel could look like this:

three separate settings

If instead of an array, we had 3 separate configuration properties:

    "configuration": {
      "properties": {
        "peacock.affectTitleBar": {
          "type": "boolean",
          "default": true,
          "description": "Specifies whether Peacock should affect the title bar."
        },
        "peacock.affectActivityBar": {
          "type": "boolean",
          "default": false,
          "description": "Specifies whether Peacock should affect the activity bar."
        },
        "peacock.affectStatusBar": {
          "type": "boolean",
          "default": false,
          "description": "Specifies whether Peacock should affect the status bar."
        }
      }
    }
@JulianG JulianG changed the title Proposal: Spread the Settings to make the visible in the settings panel Proposal: Spread the Settings to make them visible in the settings panel Mar 1, 2019
@mikeerickson
Copy link

@JulianG @johnpapa Hey gang, if this change is made, please let me know as I am working on the CLI version and read these settings accordingly.

@johnpapa
Copy link
Owner

johnpapa commented Mar 1, 2019

Neat idea. It seems no less hard coded than what exists today (meaning the extension only supports these already).

I like this because it uses the conventional settings UI and not a new command/menu.

Anyone else have an opinion?

@mikeerickson
Copy link

I like the direction, surely much clearer for the end user AND it promotes using the cool vscode setting UI

@johnpapa johnpapa mentioned this issue Mar 2, 2019
@johnpapa
Copy link
Owner

johnpapa commented Mar 2, 2019

implemented in v.0.5.0

@JulianG
Copy link
Author

JulianG commented Mar 2, 2019

awesome! I'll update asap!

@johnpapa johnpapa added this to the 1.0.0 milestone Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants