Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sheet presentation in < iOS 14.5 #36

Conversation

alejandroruizponce
Copy link

Fix proposed to fix issues when presenting manners in versions prior to iOS 14.5.

Also added dismiss closures that were set to nil in the present function.

@johnpatrickmorgan
Copy link
Owner

Thanks for raising this PR @alejandroruizponce! I'm away for a few days so I haven't been able to check it out properly yet. In the meantime, please could you explain what specific issue this solves, so I can test it? Thanks!

@johnpatrickmorgan
Copy link
Owner

Also, on first reading, it seems like the proposed change would stop presentCover from working on iOS 14 and below?

@alejandroruizponce
Copy link
Author

Also, on first reading, it seems like the proposed change would stop presentCover from working on iOS 14 and below?

Hi @johnpatrickmorgan , sorry for the time without replying, I have not been available either. Yes, there is an issue with this line in <iOS 14.5:

let asSheet = next?.route?.style.isSheet ?? false

Surely by how they are treated the presentation of manners in < iOS 14.5 is different. When presenting a sheet this line is launching several times and returning false on the last one. Which results in not presenting a sheet but a cover.

Taking into account how deprecated iOS 13 is I thought it was a better option to leave the present only for sheets and thus avoid this bug. By removing that bug and adding the backport extension, the sheets are displayed properly in both iOS 14 and 15.

@johnpatrickmorgan
Copy link
Owner

I'm still not too clear what issue this PR addresses, so I'll close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants