Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverse param is ignored #34

Closed
stevenalanstark opened this issue Apr 3, 2013 · 1 comment
Closed

reverse param is ignored #34

stevenalanstark opened this issue Apr 3, 2013 · 1 comment

Comments

@stevenalanstark
Copy link

Hello,

Setting the reverse param in addTween does nothing due to how it is coded:

            reverse: reverse || superscrollorama.settings.reverse

You can not evaluate if a boolean is set in this manner. If I pass in false then the test fails, and it uses the superscrollorama.settings.reverse anyhow.

@janpaepke
Copy link
Collaborator

Hi Steven,

you are correct. We overlooked this in the updated Marcy made, when she made the reverse option global.
I'll update this right now (as it is an easy fix) and it will be pulled to the main repo asap.

Thank you for your help.

regards,
Jan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants