Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No mention on nginx #5

Closed
andybak opened this issue Jan 16, 2012 · 5 comments
Closed

No mention on nginx #5

andybak opened this issue Jan 16, 2012 · 5 comments

Comments

@andybak
Copy link

andybak commented Jan 16, 2012

Not sure whether this is just a documentation issue (i.e. it's supported by one of the other backends i.e. WSGI) or whether it's unsupported.

Sorry if it's obvious to others but this area isn't one of my strong points - hence why I'm looking for a nice abstraction library!

@lilspikey
Copy link
Collaborator

Hi Andy,

it's not supported at the moment, purely as I was initially only doing this for an app deployed behind apache. If I understand correctly then supporting nginx with accel redirect should be really easy. Been meaning to get around to it, as I think it's possible to get it working by tweaking the wsgi backend somehow. Main issue is then documenting that nginx config.

Care to chip in? Can always meet in Brighton if you want. Hopefully once baby has settled in better sleep patterns I'll make it out to brightonpy too...

cheers,

John (aka lilspikey)

@lilspikey
Copy link
Collaborator

http://wiki.nginx.org/XSendfile

Shows it really is going to be very similar to wsgi backend, but with X-Accel-Redirect header instead of just Location.

@andybak
Copy link
Author

andybak commented Jan 16, 2012

Ah. Small world, fellow BrightonPy'er...

Just got back from an overly long holiday so might be a while until I can be of use. I do however have a real codebase and a live testing server (currently setting X-Accel-Redirect headers directly) if that would be any help.

@lilspikey
Copy link
Collaborator

I'm pretty certain of what needs changing. Perhaps if I setup a branch and make the changes I reckon are needed you could test it?

Perhaps if you could give me the example of how you're currently doing it - so I can easliy get nginx running locally etc too?

johnsensible added a commit that referenced this issue Jan 18, 2012
Needs real-life testing and documentation, but in principle sets correct
header etc.  Similar to how mod_wsgi backend works and so they now both
share code with each other.

Refs #5
@johnsensible
Copy link
Owner

Ok, I've merged the nginx branch into master now, as I've had a chance to test it running with nginx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants