Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finicky opens link in currently open browser rather than designated one in Big Sur #148

Closed
shahrviral opened this issue Nov 17, 2020 · 5 comments
Labels

Comments

@shahrviral
Copy link

I was currently able to enable Finicky on BigSur by using the defaultbrowser homebrew package, however the rules only get enforced if all the browsers are running currently. For example, if I have a rule which says open github.com in Firefox Developer Edition, it will only open in FDE if FDE is running. It no longer launches FDE. If FDE is not running, it will launch in the default browser. Am I configuring this wrong?

module.exports = {
  defaultBrowser: 'Firefox',
  handlers: [
    {
      match: /github.com\/Acme/,
      browser: 'Firefox Developer Edition',
    },
],
};

Test URL: https://github.com/Acme/my_repo

Thanks,
shahrviral

@johnste
Copy link
Owner

johnste commented Nov 17, 2020

Config looks ok to me, and I can't reproduce the issue (though I am not using the homebrew package). Not sure what I can do about this right now unfortunately. I'm trying to find the solution for #146, maybe that will solve this issue as well.

@shahrviral
Copy link
Author

I appreciate you taking a look, yeah perhaps they are related. I'll wait and keep an eye on #146

@johnste johnste reopened this Nov 21, 2020
@johnste
Copy link
Owner

johnste commented Nov 21, 2020

Mistakenly closed this issue instead of #146, will keep this open for the time being.

@johnste
Copy link
Owner

johnste commented Nov 21, 2020

Release 3.1.3 fixes #146 so might be worth testing this again

@johnste johnste added the bug label Nov 21, 2020
@shahrviral
Copy link
Author

Fixed in this release, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants