Skip to content
This repository has been archived by the owner on Jan 4, 2020. It is now read-only.

Automatically run SwiftLint locally #92

Open
garricn opened this issue Jun 2, 2017 · 6 comments
Open

Automatically run SwiftLint locally #92

garricn opened this issue Jun 2, 2017 · 6 comments
Labels
improvement

Comments

@garricn
Copy link

garricn commented Jun 2, 2017

Have you considered this to enforce formatting?
@JohnSundell
Copy link
Owner

Actually @pixyzehn already added SwiftLint for this purpose here: #89 and here: #61 😄

@JohnSundell
Copy link
Owner

That being said, we should make it run locally as well as in CI, without any manual work. How about calling it using ShellOut in a test? What do you think @pixyzehn?

@JohnSundell JohnSundell changed the title Install SwiftFormat as a build phase run script Automatically run SwiftLint locally Jun 3, 2017
@garricn
Copy link
Author

garricn commented Jun 3, 2017

Weird. I meant to write SwifFormat. I must have been really tired!

@JohnSundell
Copy link
Owner

@garricn You did, but I changed the title of the issue to reflect the task at hand 😉

@garricn
Copy link
Author

garricn commented Jun 3, 2017

Have you considered using both? They serve slightly different purposes...

@JohnSundell
Copy link
Owner

I'm personally fine with only running SwiftLint 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JohnSundell @garricn