Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery detect false-positive #297

Open
jturner869 opened this issue Jul 11, 2017 · 2 comments
Open

jQuery detect false-positive #297

jturner869 opened this issue Jul 11, 2017 · 2 comments

Comments

@jturner869
Copy link

I'm trying to scrape this web page: https://www.manheim.com/login?WT.svl=m_hdr_gnav_login

When I do this horseman does not load jQuery because it thinks jQuery is already loaded, because the site is already using $ for another function.

At first I thought it would be a good idea to make the jQuery detection more robust by doing a jQuery version lookup and parsing the jQuery name out. However that's problematic because jQuery would simply overwrite that function. SO that functionality is not a good default behavior, which lead me to the thought that horseman should allow a forced jQuery injection without checking to see if it is there, as well as the ability to initiate a force jQuery injection anywhere in the action chain. That way the user can decide if it is appropriate to overwrite the $ function.

@awlayton
Copy link
Collaborator

awlayton commented Sep 5, 2017

I would be willing to accept a PR to add "forced" jQuery injection. I am not sure if I'll have time to add it myself.

@JamesRBrown
Copy link

I think this would be a great idea. I've never contributed to a GitHub project before, but I'd be happy to work on the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants