Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect handling of preferredSize #540

Closed
johnwalley opened this issue Jan 31, 2023 · 0 comments · Fixed by #552
Closed

Incorrect handling of preferredSize #540

johnwalley opened this issue Jan 31, 2023 · 0 comments · Fixed by #552
Assignees
@johnwalley
Labels
bug Something isn't working

Comments

@johnwalley
Copy link
Owner

In pane-view.ts it looks like I divide the number of pixels by 100. All the hallmarks of a copy and paste error from the percentage case.

Screenshot 2023-01-31 at 15 58 00
@johnwalley johnwalley added the bug Something isn't working label Jan 31, 2023
@johnwalley johnwalley self-assigned this Jan 31, 2023
@johnwalley johnwalley linked a pull request Feb 9, 2023 that will close this issue
fix: handle preferredSize correctly if unit is px #552
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnwalley johnwalley

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle preferredSize correctly if unit is px johnwalley/allotment
1 participant
@johnwalley