Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract kaltura <-> session bind to a cloud function #197

Open
yinonov opened this issue Oct 30, 2020 · 1 comment
Open

Extract kaltura <-> session bind to a cloud function #197

yinonov opened this issue Oct 30, 2020 · 1 comment
Assignees
@ilirhushi
Labels
3rd party Issues involve 3rd party dependencies enhancement New feature or request refactor restructuring an existing body of code, altering its internal structure without changing its externa
Milestone
Post lunch refactor

Comments

@yinonov
Copy link
Collaborator

yinonov commented Oct 30, 2020

Is your feature request related to a problem? Please describe.
Kaltura createLiveStreamEntry is called on every session creation

Describe the solution you'd like
move this call to cloud function on firebase cloud function event trigger of session update/create
Condition this call to occur only if session is of type liveStreaming

Additional context

joie-web-app/apps/joie/src/app/session-form/containers/session-form/session-form.component.ts

Line 89 in e57e9ad

this.kalturaApiHandShakeService.createLiveStreamEntry(eventCreationDetails).subscribe(

@yinonov yinonov added enhancement New feature or request refactor restructuring an existing body of code, altering its internal structure without changing its externa 3rd party Issues involve 3rd party dependencies labels Oct 30, 2020
@yinonov yinonov added this to the Post lunch refactor milestone Oct 30, 2020
@yinonov
Copy link
Collaborator Author

yinonov commented Oct 30, 2020

fixes #195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilirhushi ilirhushi

Labels
3rd party Issues involve 3rd party dependencies enhancement New feature or request refactor restructuring an existing body of code, altering its internal structure without changing its externa
Projects
None yet
Milestone
Post lunch refactor
Development

No branches or pull requests
2 participants
@ilirhushi @yinonov