Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOINDIN-418: ApiView::addCount(), no need to loop if $content['meta']['next_page'] is set #495

Closed
ghost opened this issue Jan 21, 2014 · 1 comment

Comments

@ghost
Copy link

ghost commented Jan 21, 2014

Jira issue originally created by user tocacar:

This is just another observation as I look at the code.

If the $content variable passed to ApiView::addCount has a next_page link in it, I think you may be able to skip the counting loop and instead return the value of 'resultsperpage' from the pagination link url.

This might be overly complex for not much gain, but I thought I'd mention it as the thought did occur to me.

@ghost
Copy link
Author

ghost commented May 18, 2014

Issue was closed with resolution "Won't Fix"

@ghost ghost added the Improvement label Oct 16, 2018
@ghost ghost closed this as completed Oct 16, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants