Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp wallet view: display "accounts" as privacy levels #27

Closed
dergigi opened this issue Jan 28, 2022 · 1 comment · Fixed by #51
Closed

Revamp wallet view: display "accounts" as privacy levels #27

dergigi opened this issue Jan 28, 2022 · 1 comment · Fixed by #51
Labels
enhancement New feature or request

Comments

@dergigi
Copy link
Contributor

dergigi commented Jan 28, 2022

See the current design in Figma:

Screenshot 2022-01-28 at 15 53 21

In short:

  • Hide derivation paths and addresses from the user
  • What is currently called "Account 0" is the lowest level, i.e. "one shield"

We can add the complexity that this will hide later on if we like, but the current view is all kinds of confusing, so this would be an improvement.

Note that this concept/design is by no means final, since we can't always map "privacy level" to "accounts" (mixdepths) in a truthful one-to-one manner. But again: it's a big improvement from the current UI and should be easier to understand than mixdepths.

@dergigi dergigi added the enhancement New feature or request label Jan 28, 2022
@dergigi dergigi added this to the v0.0.4 - Make it Pretty milestone Jan 28, 2022
@ghost ghost self-assigned this Feb 3, 2022
@ghost
Copy link

ghost commented Feb 4, 2022

Regarding the Overall Privacy Level indicator:

Screenshot 2022-02-04 at 12 42 37

I like the idea of an overall privacy level to motivate users. I'm wondering how should we compute this, though.

(I'm using "privacy level" and "mixdepth" interchangeably here for simplicity.)

My first thought was simply computing a weighted average over all coins in all privacy levels. While implementing I started to doubt that this makes sense.
My thinking is this: Let's say you have one coin with privacy level 1️⃣ and another coin with privacy level 5️⃣ .
The overall average privacy level would then be 3️⃣ .

But if you spend the coin with privacy level 1️⃣ you don't get privacy as if it were a coin with privacy level level 3️⃣ . All you get is privacy level 0️⃣ . This might be confusing for the user who could assume that the overall privacy level applies to all coins when in reality it is just the average and doesn't correspone to the actual privacy of individual coins at all.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant