fix(navbar): send before earn #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dergigi
added
bug
|
I'm tempted to do all the screenshots with this change and just act as if it was correct in v0.1 all along - otherwise we'd have to redo all the screenshots for the docs again 😅 |
theborakompanioni
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how I got this wrong, but the order I did in #496 has earn before send:
Because of the new flow it should be send before earn, to get
cj-outfor FB:I got it right in the docs and in the cheatsheet (#496) - but I messed it up in the previous PR (#490).
Before 📸
After 📸