fix(sweep): reload wallet info after scheduled sweep #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theborakompanioni
added
bug
theborakompanioni
force-pushed
the
update-info-after-scheduled-sweep
branch
from
fcab8ca
to
4551ba7
Compare
|
I assume you mean based on #529, right? |
dergigi
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251.
This PR is based on #526 - please merge #526 first.This PR is based on #529 - please merge #529 first.
Before this PR, when a scheduled sweep operation ended successfully, the balance has not been updated.
After this PR, the balance will be updated as soon as the scheduler stops (either naturally or aborted).
How to test?
Invoke a scheduled sweep to external addresses and wait for completion.
After the scheduler finishes, the balance should be updated and show zero coins left (compare this to the old behaviour which would still display the balance you started with).
You can also observe the api requests in dev tools (F12) and verify that utxos are reloaded when the operation ends.