Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display fee settings on Send page #532

Merged
merged 11 commits into from
Oct 5, 2022

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Oct 4, 2022

Partly addresses #518.
Display values based on fee settings in the confirmation modal of the Send page.

"Mining fee target" will be displayed either as "targeted blocks" or "sats/vByte" (randomized or exact):
e.g.

  • "Next block" (tx_fees := 1)
  • "In 6 blocks" (tx_fees := 6)
  • "In 1,000 blocks" (tx_fees := 1000)
  • "1.001 sats/vByte" (tx_fees := 1001, tx_fees_factor := 0)
  • "9.1 - 10.9 sats/vByte" (tx_fees := 10000, tx_fees_factor := 0.9)

"Estimated Max. Collaborator Fee" will be displayed for collaborative transactions.
Calculation can be found here: https://github.com/joinmarket-webui/jam/blob/feat/display-fee-settings-in-send/src/hooks/Fees.ts#L69-L70 (Tests: https://github.com/joinmarket-webui/jam/blob/feat/display-fee-settings-in-send/src/hooks/Fees.test.ts#L22-L69)

📸

sats/vByte with randomization

sats/vByte exact

Targeted blocks

Collaborative transaction

@theborakompanioni theborakompanioni self-assigned this Oct 4, 2022
@theborakompanioni theborakompanioni added enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience labels Oct 4, 2022
@theborakompanioni theborakompanioni marked this pull request as ready for review October 4, 2022 14:00
Copy link
Contributor

@dergigi dergigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, tACK ✅

Please have a look at the adjustments I made. Feel free to merge in case you agree with them.

@dergigi
Copy link
Contributor

dergigi commented Oct 5, 2022

Screenshot for reference:

Screenshot 2022-10-05 at 16 56 18

@dergigi dergigi linked an issue Oct 5, 2022 that may be closed by this pull request
2 tasks
@dergigi
Copy link
Contributor

dergigi commented Oct 5, 2022

Calculations were always correct for me btw. - great job on the tests 👏

@theborakompanioni theborakompanioni merged commit 26f911a into master Oct 5, 2022
@theborakompanioni theborakompanioni deleted the feat/display-fee-settings-in-send branch October 5, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send: fee transparency & ability to set fees
2 participants