List of little annoyances and other stuff

[theborakompanioni]

A small list of things that stood out during testing and trial.

Please expand it according to your own assessment and let's talk about which are important before the first beta version is released.
Feel free to give an estimated priority as well.

• Inform user about coinjoin state immediately after coinjoin is initiated. Preferably via Websocket Fetch /session immediately after starting taker (otherwise user might wait up to 10 seconds to know what is going on) - Fix websocket connection #46
• Improve error message server responds with text/html #83
• When "Earn" is active, i.e. the yield generator service is running, the user can't send a transaction as a coinjoin, and vice-versa. Reason: Service already started. #87
• From @AdamISZ : When the maker is started without coins it says "maker cannot start, no coins", but it's important that it should say "no confirmed coins". See Maker service not stopping #34 (comment) - PR opened fix: improve NotEnoughCoinsForMaker error message JoinMarket-Org/joinmarket-clientserver#1190
• Improve lock/unlock mechanism #157
• Improve wording of error message when trying to send to an "invalid" address: "Invalid request format." is not meaningful. (400 InvalidRequestFormat on all assertion errors.. see wallep_rpc.py#L548)
• Prevent user from starting taker with insufficient funds (?): Check sufficient utxo confirmations exist before submitting send request  #155
  • Might be that a taker operation is started and then aborted - either unconfirmed or too little funds available (takes 60s to be resolved)
• Balance shown on Send page might not be spendable (e.g. utxo is frozen) Improve UI for account balance in send page #78

(This list should not contain missing features (e.g. "display spendable funds" or "ability to sweep"), but rather just document odd behaviour or possible improvements for existing ones.)

[dergigi]

Fetch /session immediately after starting taker (otherwise user might wait up to 10 seconds to know what is going on)

Comment from @dennisreimann: Might be a good idea to bring back the WebSocket connection, it would contain this information.

[theborakompanioni]

Fetch /session immediately after starting taker (otherwise user might wait up to 10 seconds to know what is going on)

Comment from @dennisreimann: Might be a good idea to bring back the WebSocket connection, it would contain this information.

Yeah, but I also stated it wrong - should be neutral, I did not want to propose a solution already.. will change to "Inform user about coinjoin state immediately after coinjoin is initiated.". Websocket would be great of course! 👍

[dergigi]

One more thing I noticed, not sure if it's already covered by the above: when "Earn" is active, i.e. the yield generator service is running, the user can't send a transaction as a coinjoin, and vice-versa. Reason: Service already started.

[theborakompanioni]

All of the items on the list are now either fixed, addressed in a PR or externalized as own issue. Proposing to close this issue.

[MaxHillebrand]

Well done fellas.