fix: prevent unnecessary wallet info requests #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theborakompanioni
added
bug
theborakompanioni
force-pushed
the
smart-balance-fetch
branch
2 times, most recently
from
f7d4ff5
to
a2d8e64
Compare
ghost
approved these changes
Jun 2, 2022
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix prevents unnecessary wallet info requests.
Wallet data is automatically loaded on initial page renderings.
However, if a components needs an up-to-date balance, it always triggers
reloadCurrentWalletInfo.Before this commit, this meant that the data is loaded twice when the app is refreshed on a component that needs wallet infos.
After this commit, the
reloadCurrentWalletInfomethod knows that an api request is already performed and will wait for it to be completed.Before:
After:
