Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loading state on Send page #300

Merged
3 commits merged into from
Jun 2, 2022
Merged

fix: loading state on Send page #300

3 commits merged into from
Jun 2, 2022

Conversation

theborakompanioni
Copy link
Collaborator

Closes #246.

Infer the loading state based on whether the component is "initializing" or is "waiting" for something.
The distinction has been made in order to separate between "service is enabled, but loading" and "service is disabled, but loading". Before this commit, the loading flag has never been reset if the service was disabled.

Furthermore, with this commit, the behaviour when "waiting for utxos to be reported as spent" is consistent. Service is disabled and loading flag is true.

Service is disabled if one of these conditions is met:

  • Maker operation is running
  • Taker operation is running
  • The component waits for utxos to be reported as spent (new)

@theborakompanioni theborakompanioni added the bug Something isn't working label May 30, 2022
@theborakompanioni theborakompanioni requested a review from a user May 30, 2022 16:51
@theborakompanioni theborakompanioni self-assigned this May 30, 2022
@theborakompanioni theborakompanioni changed the title fix: loading state Send page fix: loading state on Send page May 30, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works ✅

Noticed that when "earn" is active, the send page is blurred out while this isn't the case when the scheduler is running. In both cases, the form is disabled so this is really only a UI issue.

Screenshot 2022-05-30 at 22 09 15

Screenshot 2022-05-30 at 22 08 54

@theborakompanioni
Copy link
Collaborator Author

Noticed that when "earn" is active, the send page is blurred out while this isn't the case when the scheduler is running. I

Yes, indeed, that is modeled after the screens in Figma. Just disabled when taker is running, additionally blurred when maker is running. The reason for this is, I think, that the taker operation is started from this screen and the input values could potentially still be displayed (which is currently not the case).

@ghost
Copy link

ghost commented May 31, 2022

I'd say let's not make this too complex and forward looking and just go with a single style here. What do you think?

@editwentyone
Copy link

editwentyone commented May 31, 2022

The reason for this is, I think, that the taker operation is started from this screen and the input values could potentially still be displayed (which is currently not the case).

for send page while collaborative tx active: the idea is the user revisits the send page and sees the values that were chosen, thus its disabled but visible: for this idea to work its needed to see actual values inside the blocked/disabled form

for send page while earn/ jam active: it should show the user, that a complete different process from another page is active thus the complete form is unreadable, the situation is "heavier"

these are details at the end and I think we will concentrate on visual consistency later on, what do you think?

@theborakompanioni
Copy link
Collaborator Author

these are details at the end and I think we will concentrate on visual consistency later on, what do you think?

I have created another PR where the whole form is blurred if a taker or maker operation is running.
As these changes have nothing to do with the blurring, let's discuss this there so this can be merged in the meantime – if that is okay with you.

If the whole form should be blurred, apply the PR, if it is okay the way it is, just close it.

@ghost ghost merged commit db4f5ab into master Jun 2, 2022
@ghost ghost deleted the fix-send-page-loading branch June 2, 2022 13:00
@ghost
Copy link

ghost commented Jun 2, 2022

for send page while collaborative tx active: the idea is the user revisits the send page and sees the values that were chosen, thus its disabled but visible: for this idea to work its needed to see actual values inside the blocked/disabled form

for send page while earn/ jam active: it should show the user, that a complete different process from another page is active thus the complete form is unreadable, the situation is "heavier"

Ah I see. Thanks for the explanation -- I can see now where that differentiation can make sense. The thing is that at the moment we don't differentiate between a single collaborative transaction and the scheduler. That means the send page will not be blurred when the scheduler is running (see screenshots). That's why I'd say let's hold off with making that distinction for now and go with a consistent UI until we can actually implement the desired behavior. Does that make sense?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issue that keeps Send page from loading while there's an ongoing collaborative transaction
2 participants