Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not show FB create form when maker is running #384

Merged
2 commits merged into from
Jul 8, 2022

Conversation

theborakompanioni
Copy link
Collaborator

Creating a fidelity bond funding transaction includes freezing utxos, which should not be done when a taker or maker is running.
Before this commit, the FB form is hidden when the taker service is running, but not when the maker is running.
After this commit the form is hidden when any service is running, while still displaying existing FBs when the maker is active).

@theborakompanioni theborakompanioni self-assigned this Jul 7, 2022
@theborakompanioni theborakompanioni added the enhancement New feature or request label Jul 7, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Added a small spacing adjustment so that the button's top spacing remains the same no matter whether the maker is running or not.

@ghost ghost merged commit e0f51fa into master Jul 8, 2022
@ghost ghost deleted the fix-disable-fb-form-when-service-is-running branch July 8, 2022 09:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant