Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: batch unfreeze UTXOs after creating fidelity bond #388

Merged
5 commits merged into from
Jul 12, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jul 11, 2022

Resolves #366.

Give the user the option to batch-unfreeze those UTXOs that were frozen during setting up the fidelity bond.

Only those UTXOs that were batch-frozen during the creation of a fidelity bond will be unfrozen. Those that were frozen before starting the fidelity bond flow will remain frozen.

Not super pretty but good enough for now I would say.

馃摳

Screen.Recording.2022-07-11.at.10.48.42.mov

@ghost ghost added the enhancement New feature or request label Jul 11, 2022
@ghost ghost requested a review from theborakompanioni July 11, 2022 08:52
@ghost ghost self-assigned this Jul 11, 2022
@ghost ghost changed the title Batch unfreeze feat: batch unfreeze UTXOs after creating fidelity bond Jul 11, 2022
@dergigi
Copy link
Contributor

dergigi commented Jul 11, 2022

That looks fantastic! Will do my best to test & review soon.

@theborakompanioni
Copy link
Collaborator

Looks good. 馃挭

Only concern is the timeout after which wallet data is reloaded (TIMEOUT_RELOAD_UTXOS_AFTER_FB_CREATE_MS). On mainnet, this might be very different from a local regtest setup. Would it be difficult to wait for utxos used for the FB to be removed from the wallet (just like on the Send page)? You'd get the inputs used from the direct-send response (or alternatively, the used utxos are already known before sending).

UI suggestions:

  • probably remove the margin-bottom of .utxoSummaryIcon class.

@ghost
Copy link
Author

ghost commented Jul 11, 2022

Would it be difficult to wait for utxos used for the FB to be removed from the wallet (just like on the Send page)?

Good point. Posted a quick fix. Hope I got it right. Could you be so kind and have another look if it all makes sense?

Copy link
Contributor

@MaxHillebrand MaxHillebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@ghost ghost merged commit efa3361 into master Jul 12, 2022
@ghost ghost deleted the batch-unfreeze branch July 12, 2022 07:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch unfreeze UTXOs after creating a fidelity bond
3 participants