Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spacing in jar overlay header and onKeyDown #421

Merged
2 commits merged into from
Jul 22, 2022
Merged

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Jul 21, 2022

Fixes a small artifact in the jar overlay header and the onKeyDown handling (did not fire when the outer most element lost focus).

📸

Before

image

After

image

@theborakompanioni theborakompanioni added the UI/UX Issue related to cosmetics, design, or user experience label Jul 21, 2022
@theborakompanioni theborakompanioni self-assigned this Jul 21, 2022
@theborakompanioni theborakompanioni changed the title fix: spacing in jar overlay header fix: spacing in jar overlay header and onKeyDown Jul 21, 2022
@theborakompanioni theborakompanioni force-pushed the fix-jar-overview-header branch 2 times, most recently from 12b967e to e55e8fc Compare July 21, 2022 16:51
@theborakompanioni theborakompanioni marked this pull request as ready for review July 21, 2022 16:54
@theborakompanioni theborakompanioni requested a review from a user July 21, 2022 16:55
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@ghost ghost merged commit 24c0107 into master Jul 22, 2022
@ghost ghost deleted the fix-jar-overview-header branch July 22, 2022 09:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant