Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(settings): add link to Matrix and Jam's twitter #436

Merged
merged 5 commits into from
Aug 1, 2022
Merged

feat(settings): add link to Matrix and Jam's twitter #436

merged 5 commits into from
Aug 1, 2022

Conversation

dergigi
Copy link
Contributor

@dergigi dergigi commented Aug 1, 2022

In short:

  • add link to Jam's twitter (@JamAppOrg)
  • add link to the Matrix room
  • fix GitHub link (repo renamed to /jam)

Screenshot 2022-08-01 at 12-27-17 Jam for JoinMarket

Screenshot 2022-08-01 at 12-27-39 Jam for JoinMarket

@dergigi dergigi added the enhancement New feature or request label Aug 1, 2022
@dergigi dergigi requested review from theborakompanioni and a user August 1, 2022 10:28
@dergigi dergigi self-assigned this Aug 1, 2022
theborakompanioni
theborakompanioni approved these changes Aug 1, 2022
View reviewed changes
Copy link
Collaborator

@theborakompanioni theborakompanioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some links to "joinmarket-webui/joinmarket-webui" in other files (markdown, package.json), but I think you got all "in app" ones.

✔️

@dergigi
Copy link
Contributor Author

dergigi commented Aug 1, 2022

There are some links to "joinmarket-webui/joinmarket-webui" in other files

Yes, but I didn't want to rewrite the changelog history (and the links should still work because GitHub does an auto-redirect).

@dergigi dergigi merged commit ca3cc20 into master Aug 1, 2022
@dergigi dergigi deleted the add-jam-twitter branch August 1, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theborakompanioni theborakompanioni theborakompanioni approved these changes

@MaxHillebrand MaxHillebrand MaxHillebrand approved these changes

Assignees

@dergigi dergigi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dergigi @theborakompanioni @MaxHillebrand