-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sorting and filtering to earn report #451
Conversation
We can also omit it for now if you're not happy with it. I feel like it's not super essential to have. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "my inputs" or "my amounts" as table header?
Maybe for pagination a simple "load more" button at the bottom of the table? Seems like less ui clutter.
Pagination is nice (maybe needs a bit of a cleaner UI to feel less cluttered) but I feel like it'd be more interesting for the orderbook than for the earn report since the orderbook will be hundreds of entries long by default. |
Very valid point. Any immediate ideas or recommendations on the styling? Or should it be added and adapted in an upcoming version? |
The easiest would probably be to come up with a UI and add it in one go to both tables? 🤔 |
I'll be removing the pagination for now - it's not the best in terms of UI/UX. Will be readding it in a new PR to the Earn Report and Orderbook components. |
const entry = toEarnReportEntry(item) | ||
return ( | ||
<Row key={item.id} item={item}> | ||
<Cell>{entry.timestamp.toLocaleString()}</Cell> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally prefer ISO strings for timestamps. Might be a personal thing though. Any thoughts? Not sure what we use in other places throughout the app. Might be that we're a bit inconsistent there.
ping @dnlggr |
Adds
pagination,sorting and filtering to Earnings Report overlay.Was not quite sure how to best style the pagination. Not that happy with the result. Suggestions welcome!
Also, any ideas for improved wording of the table headings?
📸