feat: click on active "joining" icon opens relevant screen

[theborakompanioni]

Resolves #320.

Before this commit, the "Joining" text+icon in the header nav was not clickable.
After this commit, the icon in the header nav is clickable and will either link to "Earn", "Jam" or "Send" screen.

Additional changes:

• Added schedule property to ServiceInfo
• Changed "Joining" icon color from gray to green (like in the ticket screenshot)
• Text "Joining" is only shown on xs and sm screens (side nav)
• Added Joining indicator to "Send" nav link when single collaborative tx is active (debatable!)

These changes need JM built from the current master (at least including commit 6ec5c35c).

Relevant commits are also part of #461 and have been cherry-picked.

📸

[ghost]

With the activity indicator on the "Send" tab--do we even need the "Joining" indicator anymore? I almost feel like we can remove it entirely now, what do you think?

[ghost]

With the schedule in the session, we can probably also remove the forced schedule polling in the Jam screen right? If so I'll create an issue for that.

[theborakompanioni]

With the activity indicator on the "Send" tab--do we even need the "Joining" indicator anymore? I almost feel like we can remove it entirely now, what do you think?

Either this, or remove the dots from the navbar links - please free me from the burden of making UI related decisions 😅

With the schedule in the session, we can probably also remove the forced schedule polling in the Jam screen right? If so I'll create an issue for that.

Yes, that's true!

[ghost]

Either this, or remove the dots from the navbar links - please free me from the burden of making UI related decisions 😅

Let's defer the decision by dropping the "Joining"--I never liked the wording anyway. For now at least. The activity indicators do look a bit crowded up there but they're fine for now. A nice next step would be dropping those as well and replacing them with a nicely looking activity indicator (either in the header or in the footer) similar to the "Joining" thing but one that looks better and differentiates between the three different possible activities. Let's not wait around for designs though since this is a quite important PR (because of the schedule in the session response). What do you think?

[dergigi]

Let's defer the decision by dropping the "Joining"--I never liked the wording anyway.

+1

[theborakompanioni]

Thanks for your inputs @dnlggr. Ready for re-review.

[dergigi]

Ah, damn, just saw this now.

The way I understood it is keep the icon, but remove the "Joining" text 😬

@theborakompanioni what do you say? I think having the icon (and the functionality added in this PR that leads you to the appropriate page when you click on it) makes a ton of sense.

[theborakompanioni]

@theborakompanioni what do you say? I think having the icon (and the functionality added in this PR that leads you to the appropriate page when you click on it) makes a ton of sense.

Can do! It is a matter of reverting de86014 to come back to the original functionality. The "Joining" text will only appear in the mobile menu, as it would look rather weird without text.

I think having both (activitiy inidicator and the icon on the right side) is fine. Will open a PR.

[dergigi]

Will open a PR.

Excellent, thank you!

[theborakompanioni]

Will open a PR.

Excellent, thank you!

See #474