Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proper margin for sweep button on invalid inputs #471

Merged
merged 1 commit into from
Aug 18, 2022
Merged

fix: proper margin for sweep button on invalid inputs #471

merged 1 commit into from
Aug 18, 2022

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Aug 15, 2022 •
edited

Fixes a small visual glitch on invalid input forms containing a button, e.g. sweep button.

Before

After

@theborakompanioni theborakompanioni added bug Something isn't working UI/UX Issue related to cosmetics, design, or user experience labels Aug 15, 2022
@theborakompanioni theborakompanioni self-assigned this Aug 15, 2022
@theborakompanioni theborakompanioni marked this pull request as ready for review August 15, 2022 15:16
@dergigi dergigi self-requested a review August 18, 2022 11:40
dergigi
dergigi approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@dergigi dergigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! tACK ✅

@dergigi dergigi merged commit 4a20c9f into master Aug 18, 2022
@dergigi dergigi deleted the fix-invalid-form-sweep-btn-margin branch August 18, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dergigi dergigi dergigi approved these changes

@editwentyone editwentyone Awaiting requested review from editwentyone

Assignees

@theborakompanioni theborakompanioni

Labels
bug Something isn't working UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theborakompanioni @dergigi