-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actions bot needs to be updated to properly mention album name with multiple contributing artists under their respective headings #16
Comments
I wouldnt be too sure about that since @Smaltin has an uncanny way of finding Japanese artists with random characters. The library extracts and separates by |
I don't understand this line. By multiple artists I meant that in an album there could be a few songs that have had collaborations with other artists. Then in that case they are separated by But if you see this snippet from the dat file generated from the recent commit:
For a single song containing multiple artists, the output as shown above is what you would get for an individual song.
I know, and I agree with that. This issue just belongs to this summary file because it looks kinda obnoxious when you randomly come across multiple artists written with joint forward slashes. 😅
Oh boi! 😂 |
Actually, come to think about it Im torn because on the one hand, it would definitely be nice to have them listed properly. On the other hand, maintaining a whole gist sounds like making a second library which sounds redundant :/ A ctrl + f for k-391 would still find the collab with AW as well as any solo albums. All im saying is that I wont maintain it myself unless i can automate it (i probably can maybe maybe not) PS with mdrp are you getting more mp3's? Just wondering cuz hey album art + drp definitely got me into mp3's more |
It doesn't sound like there would be too much work in maintaining a gist because afterall it's just names of artists containing a forward slash in their names. I would be happy to maintain that list. I'll have to put more time into researching this stuff. A way to check whether "artist with forward slashes in name" is real or not, maybe through spotify or youtube music ( Feel free to close this issue for the time being. I'll reopen it when I find something.
Yeah, it's been a mix of situations that got me into mp3s. College got me into discord, and due to some recent personal circumstances I have a limited daily internet. So I had to stop using spotify and get into r/DataHoarders stuff. And now when I see my collection so organised and ✨ rich with art ✨ it feel's rewarding in a way. (ps a big shoutout to @dsdude123 for this idea and starting this project and to you and @Smaltin for developing this project further!!!) |
Since multiple artists are now officially added in the Library folder, I've noticed that when multiple artist names are present in the song's metadata and extracted they're separated by forward slash. This is also visible in some parts of the file Albums_in_MDRP such as:
Music-Discord-Rich-Presence-Library/Albums_in_MDRP.txt
Line 910 in 3a4cd04
And since the forward slash appears to be the delimiter for multiple artists in a mp3 tag, so what i'm suggesting is that I take this album name and mention it under all the artists' heading in this file whose names are joined together with a forward slash.
Example referring this line, I'd put
Play
under their (Alan Walker
,K-391
,Tungevaag
,Mangoo
) headingsBut there also also exceptions in this 'forward-slash-delimiter' rule where artists who have a forward slash in their name as on this line with the band
AC/DC
could be separated intoAC
&DC
which I'm sure no one would like 😄Music-Discord-Rich-Presence-Library/Albums_in_MDRP.txt
Line 23 in 3a4cd04
So, I would either have to add and maintain a whitelist or use an API to check whether "the artist with forward slashes in the name" exists or not (for this I would have to search for an API, or find a way to get that information)
If this plan is approved, I will work on this when I get time during the weekends.
If you have some suggestions to deal with this issue, then do let me know and I would be happy to consider them.
The text was updated successfully, but these errors were encountered: