-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Typos in Green version #339
Comments
Corrections Made:
Non-Straightforward Corrections:
--> Apostrophes were used because the text tileset does not have a quotation mark. Will change to uppercase to denote proper nouns and nicknames like the rest of the game.
--> Running up against character limit for lines. Used a thesaurus for some words to shorten length. |
fixed in commit 9642a95 |
Just a reminder about the two other typos (Oak and Seiga) since you didn't address those, in case you forgot. For Dodrio: since 'embodied' was a better wording, you can still make use of word breaks across lines (two choices here, 'em-bod-ied'), the Red/Blue Pokédex entries use them extensively and you have some extra space on the next line. For instance:
For Haunter this should work?
|
Good ideas all around. I did forget a few things. I looked into the Oak dex rating. There already is an exclamation mark, but there is an issue with line length. Each line can have a max of 18 characters including spaces. EXCEPT for the last line before a line scroll because the flashing cursor takes up the 18th space. As you can see below, the cursor overwrites the exclamation point. Not enough space to hyphenate "entirely" upwards to the top line. I'm open to ideas here. "Wholly"? "Fully"? |
I don't see a good answer either, it's tricky! I would personally prefer to remain conservative in this case, and leave the small typo rather than changing the original translation... Although if change there must be I guess 'fully' would be the better option. |
Very elegant solution! It looks great. |
Reporting a few typos I noticed during my playthrough of ShinGreen:
Pokedex:
Oak dialogue is missing a period:
Orange champion dialogue:
The text was updated successfully, but these errors were encountered: