Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Typos in Green version #339

Open
PokefanMarcel opened this issue Apr 21, 2024 · 7 comments
Open

Bug: Typos in Green version #339

PokefanMarcel opened this issue Apr 21, 2024 · 7 comments
Labels
bug Something isn't working resolved - next patch Resolved and slated for the next release

Comments

@PokefanMarcel
Copy link

Reporting a few typos I noticed during my playthrough of ShinGreen:

Pokedex:

  • Lickitung: like an arm
  • Paras: wrong opening quotation mark (should be `, not ')
  • Alakazam: at will (no dash)
  • Rhyhorn: extra period at the end
  • Lapras: extra period at the end
  • Dodrio: embodied
  • Oddish: opening quotation mark
  • Poliwrath: extra period at the end
  • Electrode: opening quotation mark
  • Seaking: extra period at the end
  • Haunter: in the dark
  • Hitmonchan: missing period at the end of first sentence

Oak dialogue is missing a period:

  • your Pokédex is entirely complete*.* Congratulations!

Orange champion dialogue:

  • Seiga should be capitalized as SEIGA to be consistent with all other names in the game
@PokefanMarcel PokefanMarcel added the bug Something isn't working label Apr 21, 2024
@jojobear13
Copy link
Owner

Corrections Made:

  • Lickitung: like an arm
    
  • Alakazam: at will (no dash)
    
  • Rhyhorn: extra period at the end
    
  • Lapras: extra period at the end
    
  • Poliwrath: extra period at the end
    
  • Seaking: extra period at the end
    
  • Hitmonchan: missing period at the end of first sentence
    

Non-Straightforward Corrections:

  • Paras: wrong opening quotation mark (should be `, not ')
    
  • Oddish: opening quotation mark
    
  • Electrode: opening quotation mark
    

--> Apostrophes were used because the text tileset does not have a quotation mark. Will change to uppercase to denote proper nouns and nicknames like the rest of the game.

  • Dodrio: embodied
    
  • Haunter: in the dark
    

--> Running up against character limit for lines. Used a thesaurus for some words to shorten length.

@jojobear13
Copy link
Owner

fixed in commit 9642a95

@jojobear13 jojobear13 added the resolved - next patch Resolved and slated for the next release label Apr 22, 2024
@PokefanMarcel
Copy link
Author

Just a reminder about the two other typos (Oak and Seiga) since you didn't address those, in case you forgot.

For Dodrio: since 'embodied' was a better wording, you can still make use of word breaks across lines (two choices here, 'em-bod-ied'), the Red/Blue Pokédex entries use them extensively and you have some extra space on the next line. For instance:

_DodrioDexEntry::
	text "An odd and rare"
	next "3-headed species."
	next "Joy, sadness, and"
	
	page "anger are embod-"
	next "ied in each head"
	next "respectively"
	dex

For Haunter this should work?

_HaunterDexEntry::
	text "If you get the"
	next "feeling of being"
	next "watched in the"
	
	page "dark when nobody"
	next "is around, a"
	next "HAUNTER is there"
	dex

@jojobear13 jojobear13 added investigate Looking into this and removed resolved - next patch Resolved and slated for the next release labels Apr 25, 2024
@jojobear13
Copy link
Owner

jojobear13 commented Apr 25, 2024

Good ideas all around. I did forget a few things.

I looked into the Oak dex rating. There already is an exclamation mark, but there is an issue with line length. Each line can have a max of 18 characters including spaces. EXCEPT for the last line before a line scroll because the flashing cursor takes up the 18th space. As you can see below, the cursor overwrites the exclamation point.

Not enough space to hyphenate "entirely" upwards to the top line. I'm open to ideas here. "Wholly"? "Fully"?

image

@PokefanMarcel
Copy link
Author

I don't see a good answer either, it's tricky! I would personally prefer to remain conservative in this case, and leave the small typo rather than changing the original translation...

Although if change there must be I guess 'fully' would be the better option.

@jojobear13
Copy link
Owner

I think I found a good solution. I discovered an unused text-function character that auto-scrolls the line without a button press or printing the flashing cursor. All I had to do was add in a 30-frame delay so that the first line is legible before it goes away.

ezgif-3-35113a2810

@jojobear13 jojobear13 added resolved - next patch Resolved and slated for the next release and removed investigate Looking into this labels Apr 30, 2024
@PokefanMarcel
Copy link
Author

Very elegant solution! It looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolved - next patch Resolved and slated for the next release
Projects
None yet
Development

No branches or pull requests

2 participants