Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mounting FontAwesome Pro no longer works #594

Closed
2 tasks done
D3SOX opened this issue Mar 19, 2024 · 5 comments
Closed
2 tasks done

Mounting FontAwesome Pro no longer works #594

D3SOX opened this issue Mar 19, 2024 · 5 comments
Labels
bug 🐛 Something isn't working next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed.

Comments

@D3SOX
Copy link

D3SOX commented Mar 19, 2024

Is there an existing issue for this?

Current Behavior

After updating to 24.3.19 this way from the docs to mount FontAwesome Pro results in missing icons when mounting version 6.4.2 in my case.
image

Expected Behavior

Work like before

Steps To Reproduce

Try to mount FontAwesome Pro

pialert.conf

I don't think that's relevant

docker-compose.yml

version: "3"
services:
  pialert:
    container_name: pialert
    image: "jokobsk/pi.alert:latest"
    network_mode: "host"
    restart: unless-stopped
    env_file:
      - .env
    volumes:
      - ${APP_DATA_LOCATION}/pialert/config:/home/pi/pialert/config
      - ${APP_DATA_LOCATION}/pialert/db/:/home/pi/pialert/db/
      # FontAwesome Pro
      - /home/nico/pialert/fontawesome-pro-6.4.2-web:/home/pi/pialert/front/lib/AdminLTE/bower_components/font-awesome:ro
    environment:
      - TZ=${TZ}
      - HOST_USER_ID=${HOST_USER_ID}
      - HOST_USER_GID=${HOST_USER_GID}
      - PORT=${PORT}
      - LOG_LEVEL=${LOG_LEVEL}

What branch are you running?

Production

pialert.log

No response

Debug enabled

  • I have read and followed the steps in the wiki link above and provided the required debug logs and the log section covers the time when the issue occurs.
@D3SOX D3SOX added the bug 🐛 Something isn't working label Mar 19, 2024
@jokob-sk
Copy link
Owner

jokob-sk commented Mar 19, 2024

Hi @D3SOX ,

Thanks for the report.

Can you try to test the dev image once this build finishes: https://github.com/jokob-sk/Pi.Alert/actions/runs/8342660269?

version: "3"
services:
  pialert:
    container_name: pialert
    image: "jokobsk/pi.alert_dev:latest"
    network_mode: "host"
    restart: unless-stopped
    env_file:
      - .env
    volumes:
      - ${APP_DATA_LOCATION}/pialert/config:/home/pi/pialert/config
      - ${APP_DATA_LOCATION}/pialert/db/:/home/pi/pialert/db/
      # FontAwesome Pro
      - /home/nico/pialert/fontawesome-pro-6.4.2-web:/home/pi/pialert/front/lib/AdminLTE/bower_components/font-awesome:ro
    environment:
      - TZ=${TZ}
      - HOST_USER_ID=${HOST_USER_ID}
      - HOST_USER_GID=${HOST_USER_GID}
      - PORT=${PORT}
      - LOG_LEVEL=${LOG_LEVEL}

@jokob-sk jokob-sk added the Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress. label Mar 19, 2024
@D3SOX
Copy link
Author

D3SOX commented Mar 19, 2024

Works fine thanks for the quick fix. Btw also with the new version the site reloads around 20 times when it's open while starting. Is this intended behavior?

@jokob-sk jokob-sk added next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed. and removed Waiting for reply⏳ Waiting for the original poster to respond, or discussion in progress. labels Mar 19, 2024
@jokob-sk
Copy link
Owner

Great!

The reloads are intended, although not ideal. I will work on fine-tuning the first load, for now, it's necessary to make sure all resources are loaded after the cache is emptied. This is only done once per session, so I now deem this an acceptable drawback, but definitely plan to improve the experience. Happy for anyone to help out as well.

@jimmybrancaccio
Copy link

I can also confirm using the dev image resolves the issue. I believe the problem was that it was trying to access FontAwesome using font-awesome.min.css instead of fontawesome.min.css. Thanks for the fix @jokob-sk ❤️

@jokob-sk
Copy link
Owner

released 🚀 -> closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working next release/in dev image🚀 This is coming in the next release or was already released if the issue is Closed.
Projects
None yet
Development

No branches or pull requests

3 participants