Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working Windows 10 #70

Closed
eleimt opened this issue Feb 3, 2021 · 12 comments · Fixed by #76
Closed

Not working Windows 10 #70

eleimt opened this issue Feb 3, 2021 · 12 comments · Fixed by #76
Labels

Comments

@eleimt
Copy link

eleimt commented Feb 3, 2021

Not working on Windows 10. Why?

@pyrech
Copy link
Member

pyrech commented Feb 3, 2021

Hi @eleimt
Could you run the embedded example (php vendor/jolicode/jolinotif/example/index.php) and report the output? It will help to determine if the problem comes from JoliNotif or from Toaster - the underlying library used on Windows 10

@eleimt
Copy link
Author

eleimt commented Feb 3, 2021

@pyrech
Yes, sure. My file:

<?php

use Joli\JoliNotif\Notification;
use Joli\JoliNotif\Notifier\NullNotifier;
use Joli\JoliNotif\NotifierFactory;

require __DIR__.'/vendor/autoload.php';

$notifier = NotifierFactory::create();

if (!($notifier instanceof NullNotifier)) {
    $notification =
        (new Notification())
            ->setTitle('Notification example')
            ->setBody('This is a notification example. Pretty cool isn\'t it?')
            ->setIcon(__DIR__.'/vendor/jolicode/jolinotif/example/icon-success.png')
    ;

    $result = $notifier->send($notification);

    echo 'Notification ', $result ? 'successfully sent' : 'failed', ' with ', get_class($notifier), PHP_EOL;
} else {
    echo 'No supported notifier', PHP_EOL;
}

Result:
Notification successfully sent with Joli\JoliNotif\Notifier\ToasterNotifier, but nothing not show. I think problem is Windows 10, but I dont not how to solve it.

@eleimt
Copy link
Author

eleimt commented Feb 8, 2021

@pyrech

@pyrech
Copy link
Member

pyrech commented Feb 9, 2021

I will need to test it on a windows 10 computer when I can (my daily laptop is on Linux)

@eleimt
Copy link
Author

eleimt commented Feb 9, 2021

Okay, thanks.

@eleimt
Copy link
Author

eleimt commented Feb 13, 2021

@pyrech
I think the problem is on my side. There are some mistakes with toast.
Notifications can be seen in the message bar only after a system reboot. I don't know how to fix this..

@eleimt
Copy link
Author

eleimt commented Feb 14, 2021

@pyrech
This is working https://github.com/mikaelbr/node-notifier, but jolicode/JoliNoti not :(

@pyrech
Copy link
Member

pyrech commented Feb 14, 2021

Yes, I reproduced the error on my Windows 10. I tried a few things but didn't find a solution yet. I will keep you informed here if I find something 😉

@eleimt
Copy link
Author

eleimt commented Feb 14, 2021

@pyrech
Okay, thanks 👍

@pyrech
Copy link
Member

pyrech commented Mar 6, 2021

@eleimt Finally found a workaround to fix this issue in #76. I plan to release it as 2.3.0 soon 😉

@eleimt
Copy link
Author

eleimt commented Mar 6, 2021

@pyrech
Coole, very much. Thanks. Wait.. 🙂

@pyrech pyrech closed this as completed in #76 Mar 7, 2021
@eleimt
Copy link
Author

eleimt commented Mar 7, 2021

@pyrech
It's worked, beautiful. Theanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants