Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repack command: merge local box config? #305

Closed
SebLours opened this issue Mar 3, 2024 · 4 comments
Closed

Repack command: merge local box config? #305

SebLours opened this issue Mar 3, 2024 · 4 comments

Comments

@SebLours
Copy link
Contributor

SebLours commented Mar 3, 2024

Hello!

I encounter a problem with the repackcommand.

I use Twig to render complex config files.
Twig has a \Twig\TwigTest class to implement the test operator.

With the current box configuration, the Test files are blacklisted
https://github.com/jolicode/castor/blob/main/tools/phar/box.linux-amd64.json#L9

When i repack my app, i have an error Class "Twig\TwigTest" not found

I can go around this problem adding this configuration in the Castor box config file:

"files": [
    "../../../vendor/twig/twig/src/TwigTest.php"
],

Did you think it could be a feature to allow merging a local box config file?

Thanks!

@lyrixx
Copy link
Member

lyrixx commented Mar 4, 2024

Did you think it could be a feature to allow merging a local box config file?

Yes 👍🏼 Do you want to work on a PR?

Thanks for the bug report

@SebLours
Copy link
Contributor Author

SebLours commented Mar 4, 2024

Yes 👍🏼 Do you want to work on a PR?

Yes, I can!

@SebLours
Copy link
Contributor Author

SebLours commented Mar 9, 2024

@lyrixx I propose this PR #318

Did you think this simple solution is convenant? or introduce an option in the repack command?

@jacquesbh
Copy link

I literally have this issue right now ^^.

Thank you @SebLours for the tips!

@pyrech pyrech closed this as completed Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants