JVM agent cleanup fix for v1.1.3 #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting a deadlock on shutdown
From the getThreadGroup() Javadoc: Returns the thread group to which this thread belongs. This method returns null if this thread has died (been stopped).
|
Also fixed a possible NPE in cleanup, see commit message. |
|
Thanks for the patch, I'll will have look at the weekend. |
rhuss
added a commit
that referenced
this pull request
Sep 27, 2013
|
I added you fix manually. Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relevant change is in
CleanupThread.java, it adds another non-daemon thread that should be ignored, created by Tanuki JSW and serving the exact same purpose as Jolokia's shutdown thread (they're effectively blocking each other).