Upgrade httpclient-osgi 4.3.3 -> 4.3.6 #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the heads up. Strange to see such a breaking change in a patch level version of httpclient, though. will hopefully have time to review and intergrate this PR soon. Thanks ! |
|
Yeah, I was surprised to see that change in 4.3.6 as well. Another way this upgrade could be done is to remove the transitive dep exclusions from httpclient-osgi, and then httpcore should be picked up transitively instead of requiring the direct dep on httpcore. |
Note, starting in 4.3.6, the httpcore classes are no longer bundled with httpclient-osgi, so a separate dependency declaration is required. See https://issues.apache.org/jira/browse/HTTPCLIENT-1558
rhuss
force-pushed
the
httpcomponents-upgrade
branch
from
4cc6fb2
to
d053569
Compare
|
thanks again, and sorry for the long delay ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, starting in 4.3.6, the httpcore classes are no longer bundled
with httpclient-osgi, so a separate dependency declaration is required.
See https://issues.apache.org/jira/browse/HTTPCLIENT-1558