Improve proxy denylist #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolokia attempts to prevent LDAP based JNDI injection attacks by applying a default denylist to JMX service URLs. However, the pattern matching that is done with this list is case sensitive. This allows for an easy bypass of the protection.
Updated the Jolokia proxy documentation to mention that whitelists are matched case insensitive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Jolokia attempts to prevent LDAP based JNDI injection attacks by applying a default denylist to JMX service URLs that are supplied in proxy-mode. However, the pattern matching that is done with this list is case sensitive. This allows for an easy bypass of the protection. The following JMX service URL passes the filter and causes an outbound LDAP connection:
I hope you don't mind the public disclosure, but I estimate the impact of this issue quite low.
/kind enhancement
Release Note