Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal Feedback #1

Open
3 tasks done
s-pangburn opened this issue Aug 6, 2018 · 0 comments
Open
3 tasks done

Proposal Feedback #1

s-pangburn opened this issue Aug 6, 2018 · 0 comments
Assignees

Comments

@s-pangburn
Copy link
Collaborator

s-pangburn commented Aug 6, 2018

MVP List

Looks good! Great job Jose! 馃檪


Database Schema

  • Your bullet points underneath each table should be formatted using backticks to describe code or column names. Example:
    • user_id references Users
    • photo_id references Photos
    • index on [:photo_id, :user_id], unique: true
    • index on :user_id, unique: true

Backend Routes

These also look good!


Frontend Routes and Components

  • You'll probably have to build this out more. These aren't routes so much as general ideas for pages. Use Bluebird as a reference.

Sample State

  • You should have slices of state for ui and session as well as errors. If you're not sure exactly why things are done this way, feel free to ask me about it!

Overall, great job Jose! Just a few changes here and there and you'll be ready to start tomorrow 馃憣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants