Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogfileRetention does not cleanup properly for Digits #307

Closed
mdax82 opened this issue Aug 10, 2021 · 2 comments
Closed

LogfileRetention does not cleanup properly for Digits #307

mdax82 opened this issue Aug 10, 2021 · 2 comments

Comments

@mdax82
Copy link

mdax82 commented Aug 10, 2021

It seems the cleanup of old stored images is not working properly. I recognized it for "Digit" so far:

setting:

[Digits]
LogImageLocation = /log/digit
LogfileRetentionInDays = 2

Though it does not keep only 2 days - the data is stored infinite.

At some point based on the amount of data in /log/digit/ every night at 1st run after midnight watermeter crashed. Though it should not have hit the FAT32 limitations at that point.

Analog which has similar setting

[Analog]
LogImageLocation = /log/analog
LogfileRetentionInDays = 2

does not seem to have the issue.

RemoveOldLogs would be called at every execution not just once per day right?

Running master - v8.0.5 - 2021-08-01 but based on the data in /log/digit it was an issue since I setup v8 from scratch.

thx

@jomjol
Copy link
Owner

jomjol commented Aug 10, 2021

Thanks for your feedback. It's possible, that there are some leaks in the code in this part. An extended test and maybe new revision could be done. Currently I'm not following this directly, as I don't have capacity to do so.
I'll put it on the list of long term topics.
Best regards,
jomjol

@jomjol jomjol closed this as completed Aug 10, 2021
@mdax82
Copy link
Author

mdax82 commented Aug 10, 2021

Thanks, no immediate issue at all I had it enabled for debug but forgot to disable ;) Besides this it works like a charme 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants