Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] TimeDomainFilter does not perform overlap #67

Open
jomy-kk opened this issue May 13, 2023 · 0 comments
Open

[BUG] TimeDomainFilter does not perform overlap #67

jomy-kk opened this issue May 13, 2023 · 0 comments
Assignees
Labels
fix Fix a feature

Comments

@jomy-kk
Copy link
Owner

jomy-kk commented May 13, 2023

Describe the bug
Overlap is ignored.

Modules
biosignals

To Reproduce
Instructions that reproduce the behavior:

x = Biosignal.load(biosignal_path)
median_filter1 = TimeDomainFilter(ConvolutionOperation.MEDIAN, timedelta(seconds=3), timedelta(seconds=3*0))
median_filter2 = FrequencyDomainFilter(ConvolutionOperation.MEDIAN, timedelta(seconds=3), timedelta(seconds=3*0.9))
y1 = median_filter1(x)
y1 = median_filter2(x)

The Problem
y1 and y2 are equal

Expected behavior
They should be different, because the overlap of each filter is different.

Python Version
3.11

@jomy-kk jomy-kk added the fix Fix a feature label May 13, 2023
@jomy-kk jomy-kk self-assigned this May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix a feature
Projects
None yet
Development

No branches or pull requests

1 participant