Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Switch to etherface for signature lookup #69

Closed
2 tasks done
davideaimar opened this issue Feb 24, 2023 · 1 comment · Fixed by #76
Closed
2 tasks done

[Feature]: Switch to etherface for signature lookup #69

davideaimar opened this issue Feb 24, 2023 · 1 comment · Fixed by #76
Assignees
@Jon-Becker

Comments

@davideaimar
Copy link
Contributor

Please check the following

  • This is not a duplicate request
  • I have checked that this is not in development

Type a detailed explanation of your feature request here.

I suggest to switch to etherface. As it's stated in the repository, they collect more signatures than 4bytes and openchain.xyz so it could resolve more of them. There are also error signatures.
@Jon-Becker
Copy link
Owner

I'll look into this today.

@Jon-Becker Jon-Becker self-assigned this Feb 26, 2023
@Jon-Becker Jon-Becker mentioned this issue Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jon-Becker Jon-Becker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ feat: switch to etherface over openchain Jon-Becker/heimdall-rs
2 participants
@davideaimar @Jon-Becker