Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Contract slow to decompile and with duplicated events in ABI #74

Closed
2 tasks done
davideaimar opened this issue Mar 1, 2023 · 2 comments
Closed
2 tasks done
Assignees

Comments

@davideaimar
Copy link
Contributor

Component

Decompile Module

Version

0.3.3

Please check the following

  • This is not a duplicate issue
  • I have checked the wiki and tried troubleshooting the issue

Operating System

Linux

Command used to produce the issue

heimdall decompile 0xce1f2c3139dae247bdd916056cb7c244defc8dd6 --rpc-url -vvvv

Describe the issue you are facing

The decompilation of the contract 0xce1f2c3139dae247bdd916056cb7c244defc8dd6 took 590.15 seconds, and the decompiled ABI contains duplicated events. You can check it here: gist.github.com (they're all present 9 times).

I suspect it has something to do with the recursive_map method not detecting loops, but I'm not sure. If you give me some hints, I can try to investigate further. Removing duplicates is probably an easy thing to do when building the output, but I think reducing the decompilation time is much harder.

@Jon-Becker
Copy link
Owner

image

yeah, something is wrong haha. I'll take a look today.

@Jon-Becker
Copy link
Owner

Resolved, will be fixed in 0.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants