Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typings can't be found on TypeScript 5 #598

Closed
cyruseuros opened this issue Jul 14, 2023 · 3 comments · Fixed by #599
Closed

Typings can't be found on TypeScript 5 #598

cyruseuros opened this issue Jul 14, 2023 · 3 comments · Fixed by #599
Assignees
@jonahsnider
Labels
bug Something isn't working released

Comments

@cyruseuros
Copy link
Contributor

d.ts files cannot define types for .mjs files
@cyruseuros cyruseuros mentioned this issue Jul 14, 2023
Merged
@jonahsnider jonahsnider added the bug Something isn't working label Jul 23, 2023
@jonahsnider jonahsnider self-assigned this Jul 23, 2023
@jonahsnider jonahsnider changed the title As it stands TypeScript imports for this package are broken Typings can't be found on TypeScript 5 Jul 23, 2023
@jonahsnider
Copy link
Owner

Thanks so much for reporting this and providing a fix!

@jonahsnider
Copy link
Owner

🎉 This issue has been resolved in version 4.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cyruseuros
Copy link
Contributor Author

Thanks for the quick patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonahsnider jonahsnider

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix typings for TypeScript v5 cyruseuros/convert
2 participants
@jonahsnider @cyruseuros