Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: updateById does not use parameter value #6

Closed
Abacaxi-Nelson opened this issue Jan 25, 2021 · 1 comment
Closed

Bug: updateById does not use parameter value #6

Abacaxi-Nelson opened this issue Jan 25, 2021 · 1 comment

Comments

@Abacaxi-Nelson
Copy link

Abacaxi-Nelson commented Jan 25, 2021

Hi,

https://github.com/themadmrj/chat_ui_kit/blob/3d03ae5de83906d01a4cd78bff2758be2397a0c2/lib/src/utils/controllers.dart#L182

Item here is took from _items, and reinsert few lines after. Modified value pass as parameter is not used.

Can fix it on my futur PR: #5 (comment) if you want.

@jonasN5
Copy link
Owner

jonasN5 commented Jan 25, 2021

Good find, thnx a lot! It's fine I'll change it.

@jonasN5 jonasN5 closed this as completed Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants