Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx config should hide the server version by default #104

Closed
farmergreg opened this issue Feb 2, 2022 · 4 comments
Closed

nginx config should hide the server version by default #104

farmergreg opened this issue Feb 2, 2022 · 4 comments

Comments

@farmergreg
Copy link

I think it would be good to add:

server_tokens off;

to the nginx configs

@JonasAlfredsson
Copy link
Owner

Hi farmergreg,

Thank you for your suggestion, but I am not sure it is this image's task to fiddle more than the bare minimum with configuration settings. The reason for this is that I want it to be as close to the original Nginx image as possible, with the exception of automatic certificate creation/renewal.

An easy solution would be to add a custom configuration file that is loaded before any other, e.g. a file called 00-load_there_first.conf with any settings you want to apply to all coming configurations.

@farmergreg
Copy link
Author

farmergreg commented Feb 2, 2022

Thanks @JonasAlfredsson for the fast response. I'll do that.

@JonasAlfredsson
Copy link
Owner

Are you satisfied with the solution so we can close the issue?

@farmergreg
Copy link
Author

farmergreg commented Feb 11, 2022

Thanks for asking. Using a custom config that loads first is working well for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants