New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better support for wildcard domains #92
Comments
I'd recommend using the same approach we do for other matches at the moment, with a |
Just created #94 that should solve this :) |
This should now be included in the v3.0.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the latest pull request we added support for DNS challenges, which means that we could now support wildcard domains. Creating a
server
config which looks like this:actually produces a functioning wildcard certificate, but this is not really versatile. A possible solution to this is to make something like this possible:
where we pick up the trailing comment and make the certificate request for this certificate only be
-d yourdomain.org -d *.yourdomain.org
.We probably need some more logic here to identify and extract when this should happen, and we most likely must demand that the
cert_name
=yourdomain.org
, so we can skip the tedious thing of trying to guess the "base" domain from the server_name.The text was updated successfully, but these errors were encountered: