Add JsonSchemaAs impl for IfIsHumanReadable
#717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swlynch99
force-pushed
the
schemars-if-is-human-readable
branch
from
395d896
to
bb2ab60
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #717 +/- ##
=======================================
Coverage 65.64% 65.64%
=======================================
Files 38 38
Lines 2343 2343
=======================================
Hits 1538 1538
Misses 805 805 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
IfIsHumanReadablewas added after I wrote all the existing impls so here's a bonus PR!This one is straightforward.
serde_jsonalways hasis_human_readableset to true so we use the schema for the human readable variant. I have also included a test to that effect.