Minor adjustments based on review feedback from Erik

perl-workflow · Feb 3, 2021 · fd15817 · fd15817
1 parent 7f8ba03
commit fd15817
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/t/validator_matches_date_format.t b/t/validator_matches_date_format.t
@@ -15,13 +15,19 @@ dies_ok { $validator = Workflow::Validator::MatchesDateFormat->new({}) } 'Constr
 
 dies_ok { $validator = Workflow::Validator::MatchesDateFormat->new({ date_format => bless {} }) } 'Constructor with bad parameters, we die';
 
-ok($validator = Workflow::Validator::MatchesDateFormat->new({
+lives_and { $validator = Workflow::Validator::MatchesDateFormat->new({
     date_format => '%Y-%m-%d',
-}), 'Constructor with date_format provided, should succeed');
+}), $validator } 'Constructor with date_format provided, should succeed';
+
+if (! $validator) {
+    BAIL_OUT 'validator construction failed';
+}
 
 isa_ok($validator, 'Workflow::Validator');
 
-ok($validator->validate($wf, '2005-05-13'), 'validating a legal date');
+lives_ok { $validator->validate($wf, '2005-05-13') } 'validating a legal date';
+
+lives_ok { $validator->validate($wf, '2005-05-13') } 'validating a legal date';
 
 lives_ok { $validator->validate($wf) } 'Validation without parameters, we live';