Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude coverage outside lib/ #144

Merged
merged 3 commits into from
Jul 30, 2021
Merged

Exclude coverage outside lib/ #144

merged 3 commits into from
Jul 30, 2021

Conversation

ehuelsmann
Copy link
Member

Description

Change in the build/CI system

Type of change

No code changes.

jonasbn
jonasbn approved these changes Jul 29, 2021
View reviewed changes
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets try it 👍🏻

@coveralls
Copy link

coveralls commented Jul 29, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.6%) to 84.442% when pulling 2d01034 on ehuelsmann:exclude-unrelated-coverage into 6970b65 on jonasbn:master.

jonasbn
jonasbn reviewed Jul 29, 2021
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@ehuelsmann ehuelsmann marked this pull request as draft July 29, 2021 16:15
@jonasbn jonasbn added the maintenance Maintenance of tools and configuration label Jul 29, 2021
@ehuelsmann ehuelsmann marked this pull request as ready for review July 29, 2021 20:32
@ehuelsmann
Copy link
Member Author

I think this consistently hits files in lib/ instead of in ../lib sometimes.

@ehuelsmann ehuelsmann requested a review from jonasbn July 29, 2021 20:40
@ehuelsmann
Copy link
Member Author

The fact that the total coverage drops compared to prior results, has two causes:

  • Persister/DBI/ExtraData is now included under lib/ at only 12% coverage (lowering the coverage of lib/Workflow/Persister and subdirectories)
  • Under "/", there were results from t/TestUtil.pm and t/PersisterOtherDBIFields.pm, both of which had great coverage, but which are now both excluded from the coverage result due to the ^t/ ignore instruction

jonasbn
jonasbn approved these changes Jul 30, 2021
View reviewed changes
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jonasbn jonasbn merged commit b9371bf into perl-workflow:master Jul 30, 2021
@ehuelsmann ehuelsmann deleted the exclude-unrelated-coverage branch August 3, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasbn jonasbn jonasbn approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance of tools and configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ehuelsmann @coveralls @jonasbn