Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay instantiation to prevent further logging attempts #174

Merged
merged 2 commits into from
Nov 13, 2021

Conversation

ehuelsmann
Copy link
Member

Description

Note that this commit changes 'import()' in the sense that it no
longer returns the instance. However, there's no documentation that
it should.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project, please see the contribution guidelines.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Note that this commit changes 'import()' in the sense that it no
longer returns the instance. However, there's no documentation that
it should.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 82.338% when pulling e6a47a2 on ehuelsmann:1.x-delay-instantiation into 02f3c23 on jonasbn:1.x.

Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jonasbn jonasbn merged commit 574e194 into perl-workflow:1.x Nov 13, 2021
@jonasbn jonasbn added this to the 1.58 milestone Nov 13, 2021
@jonasbn jonasbn added the maintenance Maintenance of tools and configuration label Nov 13, 2021
@jonasbn jonasbn mentioned this pull request Feb 11, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance of tools and configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants