Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction to Perl::Critic configuration #186

Merged
merged 1 commit into from Jan 28, 2022
Merged

Correction to Perl::Critic configuration #186

merged 1 commit into from Jan 28, 2022

Conversation

jonasbn
Copy link
Collaborator

@jonasbn jonasbn commented Jan 28, 2022

Description

The test suite emits a warning

The ValuesAndExpressions::ProhibitImplicitNewlines policy doesn't take a "allowed_values" option.

The options are placed under:

Perl::Critic::Policy::ValuesAndExpressions::ProhibitImplicitNewlines

But should be under:

Perl::Critic::Policy::ValuesAndExpressions::ProhibitMagicNumbers

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project, please see the contribution guidelines.
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

You might think, that this is one crazy checklist, but it is just as much written for the maintainer of the involved software :-)

@jonasbn jonasbn added this to the 1.58 milestone Jan 28, 2022
@jonasbn jonasbn added the bug label Jan 28, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.452% when pulling cfc62ac on magic_numbers into 60a6a27 on master.

ehuelsmann
ehuelsmann approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@ehuelsmann ehuelsmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ehuelsmann
Copy link
Member

Completely overlooked this in my previous reviews...

@ehuelsmann ehuelsmann merged commit 8d12a8e into master Jan 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the magic_numbers branch January 28, 2022 11:46
@jonasbn
Copy link
Collaborator Author

jonasbn commented Jan 28, 2022

Overlooking stuff happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuelsmann ehuelsmann ehuelsmann approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.58
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonasbn @coveralls @ehuelsmann