Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not clobber $EVAL_ERROR by localizing before eval #211

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

ehuelsmann
Copy link
Member

Description

Protect the caller's value of $@ by localizing it before calling eval.

Please note that only a PR for 1.x is required as 2.x (master) already has the required localizations in place.

Fixes/addresses (If applicable) # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project, please see the contribution guidelines.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ehuelsmann ehuelsmann added this to the 1.62 milestone Jan 27, 2023
@coveralls
Copy link

Coverage Status

Coverage: 82.353% (-0.009%) from 82.362% when pulling 895ca22 on fix/1.x/clobbered-eval_error into b2d7366 on 1.x.

Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved

@jonasbn jonasbn merged commit 60a1da1 into 1.x Feb 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/1.x/clobbered-eval_error branch February 11, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants