Fixed field reflection & and some def-in-def cleanup

src/brittle/core.clj

@@ -27,4 +27,10 @@
 
 
 (defn defndef [x]
-  (def a 3))
+  (def a 3))
+
+;; This is often ok.
+(defmacro ^:private defindefmacro []
+  (def b nil))
+
+(defrecord SomeRecord [])

src/eastwood/linters/misc.clj

@@ -58,12 +58,11 @@
 
 ;; Def-in-def
 
-
 (defn def-in-def [exprs]
   (doseq [expr (mapcat expr-seq exprs)
           :when (and (= (:op expr) :def)
                      (-> expr :var meta :macro not))]
-    (if (some #(= (:op %) :def) (rest (expr-seq expr)))
+    (when (some #(= (:op %) :def) (rest (expr-seq expr)))
       (println "There is a def inside" (:var expr)))))
 
 

src/eastwood/linters/reflection.clj

@@ -7,7 +7,7 @@
   (not (:method expr)))
 
 (defmethod reflective-call? :instance-field [expr]
-  (not (:method expr)))
+  (not (:field expr)))
 
 (defmethod reflective-call? :default [_] false)
 
@@ -27,7 +27,5 @@
 
 (defn reflection [exprs]
   (doseq [expr (mapcat expr-seq exprs)
-          :when (and (reflective-call? expr)
-                     (not (= "__methodImplCache"
-                             (:field-name expr))))]
+          :when (reflective-call? expr)]
     (report expr)))