Reduce undesirable :constant-test linter warnings

[jafingerhut]

Probably best done after/when implementing disabling warnings on a per-expression basis, issue #21 .

When doing so, verify whether it can be disabled for all expansions of a macro. Projects like Carmine and core.match have macros that frequently cause :constant-test and other warnings to be generated (see #108), hundreds of times each. I suspect a few well-placed disabling annotations in a few macro definitions could eliminate most of these. That would also be useful for some debug macros people have written in various projects that expand to things like (if debug-enabled (println "foo")) where debug-enabled is a ^:const Var.

[ddossot]

FTR I'm using Korma for DB access and expressions like this:

(select fruits)

yield this warning:

suspicious-expression: -> called with 1 args. (-> x) always returns x. Perhaps there are misplaced parentheses?

with eastwood 0.2.0 (version 0.1.4 doesn't report the issue).

[jafingerhut]

Thanks for the report. Yes, this is due to the change that fixed issue #93. While it eliminated some unwanted warnings, it also introduced new ones in cases like this.

I have created a new issue #114 for this, since it is different than what I thought would be a good solution, which is issue #21, but that issue does not include the capability to selectively disable warnings in library code that you would prefer not to edit.

[jafingerhut]

ddossot: I added the lines at the link to a new configuration file that will be part of Eastwood in the next release, version 0.2.1. It is not in any release yet as of this date. It should disable the kind of warnings you mention above when using Korma.

https://github.com/jonase/eastwood/blob/master/resource/config.clj#L136-L183

If you wish to try out the latest unreleased version of Eastwood to see if it improves things for you, you can follow the steps here:

https://github.com/jonase/eastwood#for-eastwood-developers

[ddossot]

Indeed:

== Eastwood 0.2.1-SNAPSHOT Clojure 1.6.0 JVM 1.8.0_20
Directories scanned for source files:
  src test
== Linting com.unbounce....db ==
== Warnings: 0 (not including reflection warnings)  Exceptions thrown: 0

0.2.1-SNAPSHOT works great with Korma 😄

[jafingerhut]

ddossot: Thank you for verifying. I will close this issue, then, since your unwanted warnings have been addressed, as well as the original purpose for which I created the issue.

[jafingerhut]

Part of Eastwood release 0.2.1